Re: add function argument name to substring and substr

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add function argument name to substring and substr
Date: 2025-03-31 22:22:14
Message-ID: CAKFQuwbPdo1MORJqnQj=eA6bGrvGu_U+8J+oTWw7QDvuX2oAQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 18, 2025 at 9:04 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:

>
> new patch attached.
>
>
I've done v4 with a delta patch.

Decided to standardize on calling the SQL Similar To regular expression
escape replaceable "escape" everywhere.

Instead of fully documenting the obsolete syntax I added a note explaining
the keyword choice difference. Removed mention of it completely from the
Pattern Matching portion of the documentation - that section has enough
going on.

I also add "Same as" references for the two pairs of entries. Not married
to them but they do seem warranted; having Pattern Matching be required
reading to make that connection seems undesirable.

David J.

Attachment Content-Type Size
v4-0001-v3-0001-substring.patch text/x-patch 11.9 KB
v4-0002-v3-0002-delta.patch text/x-patch 8.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-03-31 22:29:01 Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.
Previous Message Christoph Berg 2025-03-31 22:17:31 Re: pgsql: Add support for OAUTHBEARER SASL mechanism