From: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Joel Jacobson <joel(at)compiler(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andreas Karlsson <andreas(at)proxel(dot)se>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>, Erik Rijkers <er(at)xs4all(dot)nl>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
Date: | 2021-02-23 21:52:28 |
Message-ID: | CAJvoCuv8ibBzwresqYBokmPp06xYTht2YhMmcCVCr4Ot=jA-Kw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hey Justin,
Thank you for your review!
gram.y:16933:20: error: invalid operands to binary expression ('List' (aka
> 'struct List') and 'void *')
> Assert(**reftypes != NULL);
>
> Did you mean to write this, before the assignment of NIL ?
>
Fixed in v5 below.
> The windows build succeeded, but checks failed like:
>
> SELECT * FROM FKTABLEFORARRAYGIN WHERE ftest1 @>> 5;
> ftest1 | ftest2
> --------------+--------
> - {5} | 1
> - {3,5,2,5} | 3
> - {3,5,4,1,3} | 5
> - {5,1} | 7
> - {3,4,5,3} | 10
> -(5 rows)
> +--------+--------
> +(0 rows)
can't seem to reproduce it. Will try to debug them with the next CI check.
I suggest to generate the patch series with:
>
git format-patch -v2 origin.. -o patch/foreign-key-arrays/
>
I like this format, thanks for the suggestion!
Changelog:
- v5 (compatible with current master 2021-2-23,
commit 8deb6b38dc4c7a7fd4719ee45e4b00d62b27dffe)
* correct all reported spelling mistakes
* correct bug in "gram.y"
/Mark
Attachment | Content-Type | Size |
---|---|---|
v5-0002-fk-arrays-elems.patch | text/x-patch | 117.7 KB |
v5-0001-anyarray_anyelement_operators.patch | text/x-patch | 27.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-02-23 22:22:16 | Re: partial heap only tuples |
Previous Message | Andres Freund | 2021-02-23 21:05:45 | Re: Asynchronous and "direct" IO support for PostgreSQL. |