| From: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, David Steele <david(at)pgmasters(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at> |
| Subject: | Re: GSoC 2017: Foreign Key Arrays |
| Date: | 2017-09-24 17:50:11 |
| Message-ID: | CAJvoCuty7ZT6KrUxP=b3ownM7AoGqCOhU+vMzwv-ZdqkDPuwYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you for the review.
Please find the new patch here, with your comments taken into consideration.
However, the following comment "Related to the above: I am not sure if it
is a good idea to make ELEMENT a reserved word in column definitions. What
if the SQL standard wants to use it for something?
I think I prefer (EACH ELEMENT OF xs) over (ELEMENT xs) given how the
former is more in what I feel is the spirit of SQL. And if so we should
match it as "xs integer[] EACH ELEMENT REFERENCES t1 (x)", assuming we want
that syntax." is outside my area of expertise. The original authors should
take a look at it (Tom Lane and Marco). They had a whole discussion on the
matter, here.
https://www.postgresql.org/message-id/6256.1350613614%40sss.pgh.pa.us
Best Regards,
Mark Rofail
| Attachment | Content-Type | Size |
|---|---|---|
| Array-ELEMENT-foreign-key-v5.2.patch | text/x-patch | 125.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-09-24 18:39:03 | Re: VACUUM and ANALYZE disagreeing on what reltuples means |
| Previous Message | Peter Geoghegan | 2017-09-24 16:14:07 | Re: ICU locales and text/char(n) SortSupport on Windows |