Re: MSVC Build support with visual studio 2019

On Mon, May 27, 2019 at 8:14 PM Juan José Santamaría Flecha <
juanjo(dot)santamaria(at)gmail(dot)com> wrote:

>
> On Thu, May 23, 2019 at 3:44 AM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
>
>>
>> Updated patches are attached for all branches.
>>
>>
> I have gone through all patches and there are a couple of typos:
>

Thanks for the review.

> 1. s/prodcutname/productname/
>
> 1.1 In file: 0001-support-building-with-visual-studio-2019_v9.4.patch
> @@ -97,8 +97,9 @@
> <productname>Visual Studio 2013</productname>. Building with
> <productname>Visual Studio 2015</productname> is supported down to
> <productname>Windows Vista</> and <productname>Windows Server 2008</>.
> - Building with <productname>Visual Studio 2017</productname> is
> supported
> - down to <productname>Windows 7 SP1</> and <productname>Windows Server
> 2008 R2 SP1</>.
> + Building with <productname>Visual Studio 2017</productname> and
> + <prodcutname>Visual Studio 2019</prodcutname> are supported down to
>
> 1.2 In file:
> 0001-support-building-with-visual-studio-2019_v10_to_v9.5.patch
> @@ -97,8 +97,9 @@
> <productname>Visual Studio 2013</productname>. Building with
> <productname>Visual Studio 2015</productname> is supported down to
> <productname>Windows Vista</> and <productname>Windows Server 2008</>.
> - Building with <productname>Visual Studio 2017</productname> is
> supported
> - down to <productname>Windows 7 SP1</> and <productname>Windows Server
> 2008 R2 SP1</>.
> + Building with <productname>Visual Studio 2017</productname> and
> + <prodcutname>Visual Studio 2019</prodcutname> are supported down to
>

Corrected.

> 2. s/stuido/studio/
>
> 2.1 In file: 0001-support-building-with-visual-studio-2019_v9.4.patch
> @@ -143,12 +173,12 @@ sub DetermineVisualStudioVersion
> sub _GetVisualStudioVersion
> {
> my ($major, $minor) = @_;
> - # visual 2017 hasn't changed the nmake version to 15, so still using
> the older version for comparison.
> + # The major visual stuido that is suppored has nmake version >= 14.20
> and < 15.
>
> 2.2 In file:
> 0001-support-building-with-visual-studio-2019_v10_to_v9.5.patch
> @@ -132,12 +162,12 @@ sub DetermineVisualStudioVersion
> sub _GetVisualStudioVersion
> {
> my ($major, $minor) = @_;
> - # visual 2017 hasn't changed the nmake version to 15, so still using
> the older version for comparison.
> + # The major visual stuido that is suppored has nmake version >= 14.20
> and < 15.
>
> 2.3 In file: 0001-support-building-with-visual-studio-2019_v11.patch
> @@ -139,12 +165,12 @@ sub _GetVisualStudioVersion
> {
> my ($major, $minor) = @_;
>
> - # visual 2017 hasn't changed the nmake version to 15, so still using
> the older version for comparison.
> + # The major visual stuido that is suppored has nmake version >= 14.20
> and < 15.
>
> 2.4 In file: 0001-Support-building-with-visual-studio-2019_HEAD.patch
> @@ -106,17 +132,17 @@ sub _GetVisualStudioVersion
> {
> my ($major, $minor) = @_;
>
> - # visual 2017 hasn't changed the nmake version to 15, so still using
> the older version for comparison.
> + # The major visual stuido that is suppored has nmake version >= 14.20
> and < 15.
>

Corrected. And also 'supported' spelling is also wrong.

Updated patches are attached.

Regards,
Haribabu Kommi
Fujitsu Australia