From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: psql \setfileref |
Date: | 2016-12-02 06:40:27 |
Message-ID: | CAJrrPGeY1Q22EczoayEP5zdBbPBd8zWdssO746U-nz5pPEF-mA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 18, 2016 at 5:53 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
wrote:
> Hi
>
> 2016-11-17 12:00 GMT+01:00 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>
>>
>> Hi
>>
>> a independent implementation of parametrized queries can looks like
>> attached patch:
>>
>> this code is simple without any unexpected behave.
>>
>> parameters are used when user doesn't require escaping and when
>> PARAMETRIZED_QUERIES variable is on
>>
>> Regards
>>
>
> here is a Daniel's syntax patch
>
> The independent implementation of using query parameters is good idea, the
> patch looks well, and there is a agreement with Tom.
>
> I implemented a Daniel proposal - it is few lines, but personally I prefer
> curly bracket syntax against `` syntax. When separator is double char, then
> the correct implementation will not be simple - the bad combinations "` ``,
> `` `" should be handled better. I wrote my arguments for my design, but if
> these arguments are not important for any other, then I can accept any
> other designs.
>
>
The recent updated patch as per the agreement hasn't received any feedback
from reviewers. Moved to next CF with "needs review" status.
Regards,
Hari Babu
Fujitsu Australia
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2016-12-02 06:44:01 | Re: Danger of automatic connection reset in psql |
Previous Message | Haribabu Kommi | 2016-12-02 06:36:34 | Re: pgbench - allow backslash continuations in \set expressions |