From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | henry_boehlert(at)agilent(dot)com |
Cc: | "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #14634: On Windows pg_basebackup should write tar to stdout in binary mode |
Date: | 2017-05-03 04:32:54 |
Message-ID: | CAJrrPGeU=xWvFBvpGoHqTTGo-__iqUUFRNAZGXPGMymFWVQYXA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
[Adding -hackers mailing list]
On Fri, Apr 28, 2017 at 6:28 PM, <henry_boehlert(at)agilent(dot)com> wrote:
> The following bug has been logged on the website:
>
> Bug reference: 14634
> Logged by: Henry Boehlert
> Email address: henry_boehlert(at)agilent(dot)com
> PostgreSQL version: 9.6.2
> Operating system: Windows Server 2012 R2 6.3.9600
> Description:
>
> Executing command pg_basebackup -D -F t writes its output to stdout, which
> is open in text mode, causing LF to be converted to CR LF thus corrupting
> the resulting archive.
>
> To write the tar to stdout, on Windows stdout's mode should be temporarily
> switched to binary.
>
> https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx
>
Thanks for reporting the issue.
With the attached patch, I was able to extract the tar file that gets
generated when the tar file is written into stdout. I tested the
the compressed tar also.
This bug needs to be fixed in back branches also.
Regards,
Hari Babu
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
pg_basebackup_tar_to_stdout_windows_fix.patch | application/octet-stream | 448 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2017-05-03 05:19:16 | Re: Concurrent ALTER SEQUENCE RESTART Regression |
Previous Message | Robert Haas | 2017-05-02 18:40:38 | Re: Concurrent ALTER SEQUENCE RESTART Regression |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2017-05-03 04:38:57 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |
Previous Message | Stephen Frost | 2017-05-03 03:05:20 | Re: pg_dump emits ALTER TABLE ONLY partitioned_table |