Re: pg_hba_file_settings view patch

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Greg Stark <stark(at)mit(dot)edu>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba_file_settings view patch
Date: 2016-10-28 05:55:51
Message-ID: CAJrrPGdxW1Fd=SLjRJbvPqWTyP64BkajA55gTcpfGRWCVqhBgA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 28, 2016 at 4:17 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

> Greg Stark wrote:
>
> > The fundamental problem is that the pga_hba.conf file has some bits of
> > complex structure that aren't easily captured by linear arrays. The
> > problem I struggled with most was the keywords like "all", "samerole",
> > and "replication". A simple array of text makes it awkward to
> > distinguish those keywords from the quoted text values with the same
> > content. And then there are the ldap options which naturally would be
> > a data type like json or htab.
>
> Hmm I thought we had decided that such keywords would live in separate
> arrays, i.e. you have one array for plain names and another array for
> keyword stuff. Then it's not ambiguous anymore.

Thanks for all your opinions. Here I attached updated patch with the change
in column datatype from JSONB to TEXT array. Rest of the code changes
are same to the earlier patch.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
pg_hba_rules_2.patch application/octet-stream 47.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-10-28 06:05:02 Re: WAL consistency check facility
Previous Message Amit Kapila 2016-10-28 05:53:22 Re: Proposal: scan key push down to heap [WIP]