Re: Support logical replication of DDLs

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Wei Wang (Fujitsu)" <wangw(dot)fnst(at)fujitsu(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Support logical replication of DDLs
Date: 2023-05-12 06:33:38
Message-ID: CAJpy0uCFcts_DFnxnN22ukPz2g9yP6FeShU8GuLmX7XMwy7j4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tue, May 9, 2023 at 4:23 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Mon, May 8, 2023 at 4:31 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > On Mon, May 8, 2023 at 3:58 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > >
> > > On Tue, May 2, 2023 at 8:30 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> > > >
> > > > On Fri, Apr 28, 2023 at 5:11 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > > >
> > > > > Now, I think we can try to eliminate this entire ObjTree machinery and
> > > > > directly from the JSON blob during deparsing. We have previously also
> > > > > discussed this in an email chain at [1]. I think now the functionality
> > > > > of JSONB has also been improved and we should investigate whether it
> > > > > is feasible to directly use JSONB APIs to form the required blob.
> > > >
> > > > +1.
> > > > I will investigate this and will share my findings.
> > > >
> > >
> > >
> > > Please find the PoC patch for create-table after object-tree removal.
> >
>

Please find the new set of patches attached for object-tree removal.
Additional changes in patch 0008 only, which are:
1) create-table completion
2) create-table-as implementation
3) drop table implementation
4) 'test_ddl_deparse_regress' test failures' fixes and log files
update. All the tests pass now.
5) code refactoring

Thank You Vignesh for assisting on this.

thanks
Shveta

Attachment Content-Type Size
0002-Enhance-the-event-trigger-to-support-DDL--2023_05_12.patch application/octet-stream 33.9 KB
0001-Deparser-for-Table-DDL-commands-and-exten-2023_05_12.patch application/octet-stream 167.5 KB
0003-Add-verbose-option-for-ddl-deparse-module-2023_05_12.patch application/octet-stream 47.2 KB
0005-DDL-replication-for-Table-DDL-commands-2023_05_12.patch application/octet-stream 248.0 KB
0004-Introduce-the-test_ddl_deparse_regress-te-2023_05_12.patch application/octet-stream 977.8 KB
0006-Add-subscription-tap-test-for-DDL-replica-2023_05_12.patch application/octet-stream 20.8 KB
0007-Apply-the-DDL-change-as-that-same-user-th-2023_05_12.patch application/octet-stream 60.0 KB
0008-Create-table-object-tree-removal-2023_05_12.patch application/octet-stream 1.6 MB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Durumdara 2023-05-12 11:04:32 Window function for get the last value to extend missing rows
Previous Message Peter J. Holzer 2023-05-12 06:31:16 Re: Death postgres

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2023-05-12 06:35:33 An inefficient query caused by unnecessary PlaceHolderVar
Previous Message Kirk Wolak 2023-05-12 06:19:54 Re: psql tests hangs