Re: Re[3]: On login trigger: take three

From: Greg Nancarrow <gregn4422(at)gmail(dot)com>
To: Ivan Panchenko <wao(at)mail(dot)ru>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Subject: Re: Re[3]: On login trigger: take three
Date: 2021-06-03 03:05:50
Message-ID: CAJcOf-f6oHipLA-9SKxun=WCZ4dZwVRFVd6O=AszUXy+D5cXRA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 21, 2021 at 2:46 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, May 20, 2021 at 2:45 PM Ivan Panchenko <wao(at)mail(dot)ru> wrote:
> >
> > I have upgraded the patch for the 14th version.
> >
>
> I have some feedback on the patch:
>

I've attached an updated version of the patch.
I've applied my review comments and done a bit more tidying up of
documentation and comments.
Also, I found that the previously-posted patch was broken by
snapshot-handling changes in commit 84f5c290 (with patch applied,
resulting in a coredump during regression tests) so I've added a fix
for that too.

Regards,
Greg Nancarrow
Fujitsu Australia

Attachment Content-Type Size
v15-0001-on_client_connect_event_trigger.patch application/octet-stream 37.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2021-06-03 03:06:57 Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Previous Message David Rowley 2021-06-03 03:04:33 Re: What to call an executor node which lazily caches tuples in a hash table? (GUC)