From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
---|---|
To: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Tang, Haiying" <tanghy(dot)fnst(at)cn(dot)fujitsu(dot)com> |
Subject: | Re: Parallel INSERT (INTO ... SELECT ...) |
Date: | 2021-02-02 11:03:08 |
Message-ID: | CAJcOf-ephiFa93PS+LY=mhDLzzt==NyVq=OnRnkeQ+-Gj4LaNg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Feb 2, 2021 at 7:26 PM Hou, Zhijie <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> wrote:
>
> >
>
> Yes, I agreed,
> I was worried about the overhead it may bring too,
> we can remove this from the current patch.
>
Posting an updated set of patches. Changes are based on feedback, as
detailed below:
[Hou]
- Corrected code that tries to check for underlying query on a
relation (but must at least check for underlying query, to rule out
VALUES). More complex tests not used, due to overhead.
- Fixed comment in tests for INSERT on temp table.
[Antonin]
- Moved Gather node targetlist fix-up code to set_plan_refs() and
updated comment (Antonin)
- Added extra tests for INSERT with RETURNING clause.
Hou: the parallel_dml patches will need slight rebasing
Regards,
Greg Nancarrow
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v14-0001-Enable-parallel-SELECT-for-INSERT-INTO-.-SELECT.patch | application/octet-stream | 23.6 KB |
v14-0004-Parallel-INSERT-and-or-SELECT-for-INSERT-INTO-tests-and-doc.patch | application/octet-stream | 19.9 KB |
v14-0002-Parallel-SELECT-for-INSERT-INTO-.-SELECT-tests-and-doc.patch | application/octet-stream | 63.9 KB |
v14-0003-Enable-parallel-INSERT-and-or-SELECT-for-INSERT-INTO.patch | application/octet-stream | 44.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | japin | 2021-02-02 11:16:23 | Re: row filtering for logical replication |
Previous Message | Peter Eisentraut | 2021-02-02 10:49:32 | Re: Add primary keys to system catalogs |