From: | John Naylor <jcnaylor(at)gmail(dot)com> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WIP: a way forward on bootstrap data |
Date: | 2017-12-21 18:32:22 |
Message-ID: | CAJVSVGXAkwbk-A9QHHHf00N905kKisyQbaYwKqaRpze_gPXGfg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12/20/17, David Fetter <david(at)fetter(dot)org> wrote:
> Thanks for your hard work on this. It'll really make developing this
> part of the code a lot more pleasant.
I hope so, thanks.
> Unfortunately, it no longer applies to master. Can we get a rebase?
Hmm, it still applied for me, except when I forgot to gunzip the
larger patches. In any case, I've attached version 4 which contains
some recent improvements. It was rebased against master as of
6719b238e8f0ea. If it doesn't apply for you please let me know the
details.
--
New in this patch set:
-Remove code duplication and improve modularity in data parsing
-Update README at appropriate points
-Shift some hunks around to make patches more focused and readable
-Comment and commit message editing
-Patch 11 reduces indentation
-Patch 12 moves all the toast/index commands into the individual
catalog headers and simplifies some #includes (Note: I failed to shave
the yak of selinux, so the #include changes for contrib/sepgsql are
untested)
At this point, I think it's no longer a WIP, and will only make
further changes based on review or if I find a mistake.
Left for future projects:
-SQL generation for querying source bootstrap data
-Generating pg_type #defines
-John Naylor
Attachment | Content-Type | Size |
---|---|---|
v4-0001-Fix-typos-and-oversights-in-catalog-headers.patch | text/x-patch | 5.6 KB |
v4-0002-Cleanup-distprep-scripts.patch | text/x-patch | 8.2 KB |
v4-0003-Remove-hard-coded-schema-knowledge-about-pg_attri.patch | text/x-patch | 15.3 KB |
v4-0004-Data-conversion-infrastructure.patch | text/x-patch | 51.8 KB |
v4-0005-Mechanical-data-conversion.patch.tar.gz | application/x-gzip | 94.0 KB |
v4-0006-Hand-edits-of-data-files.patch | text/x-patch | 69.6 KB |
v4-0007-Update-catalog-scripts-to-read-data-files.patch | text/x-patch | 21.5 KB |
v4-0008-Remove-data-from-catalog-headers.patch.tar.gz | application/x-gzip | 107.9 KB |
v4-0009-Replace-oids-with-human-readable-names.patch.tar.gz | application/x-gzip | 122.7 KB |
v4-0010-Type-aliases-for-oid-lookups.patch | text/x-patch | 13.4 KB |
v4-0011-Reduce-indentation-level.patch | text/x-patch | 18.9 KB |
v4-0012-Move-toast-index-macros-to-the-pg_-catalog-header.patch | text/x-patch | 82.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Raúl Marín Rodríguez | 2017-12-21 19:33:33 | Re: [HACKERS] pow support for pgbench |
Previous Message | Robert Haas | 2017-12-21 18:21:39 | Re: ddd |