From: | John Naylor <jcnaylor(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WIP: a way forward on bootstrap data |
Date: | 2018-03-22 14:03:29 |
Message-ID: | CAJVSVGX1WbYtnE_2LNrf8dpz_O2bOOh37RjYXcbACaxPH=H68Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> On 3/21/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I've got mixed feelings about the whitespace lines between fields. They
>> seem like they are mostly bulking up the code and we could do without
>> 'em.
>> On the other hand, pgindent will insist on putting one before any
>> multi-line field comment, and so that would create inconsistent
>> formatting
>> if we don't use 'em elsewhere. Thoughts?
>
> I'll do it both ways for one header and post the results for people to look
> at.
I've attached an earlier version of pg_proc.h with both formats as I
understand them. I turned a couple comments into multi-line comments
to demonstrate. I think without spaces it's just as hard to read as
with multiple annotations. I'd vote for spaces, but then again I'm not
the one who has to read these things very often.
-John Naylor
Attachment | Content-Type | Size |
---|---|---|
pg_proc_format_nospace.h | text/x-chdr | 5.8 KB |
pg_proc_format_withspace.h | text/x-chdr | 5.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-03-22 14:07:36 | Re: [PATCH] Verify Checksums during Basebackups |
Previous Message | Tom Lane | 2018-03-22 13:58:36 | Re: WIP: a way forward on bootstrap data |