| From: | John Naylor <jcnaylor(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: a way forward on bootstrap data |
| Date: | 2018-03-27 14:33:07 |
| Message-ID: | CAJVSVGV0mfo0Gav8YTrk40SQ5HzeQ+xKfRFUtRQTM7k_9Xmc+Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>> -Maybe document examples of how to do bulk-editing of data files?
>
> +1. In the end, that's the reason we're doing all this work, so showing
> people how to benefit seems like a good thing.
I'll hold off on posting a new patchset until I add this to the
documentation, but I wanted to report on a couple of other things:
While adjusting to the 80-column limit, I encountered a separation of
concerns violation between Catalog.pm and reformat_dat_files.pl that I
hadn't noticed before. Fixing that made things easier to read, with
fewer lines of code.
Speaking of bulk editing, that would be done via adopting
reformat_dat_files.pl to the task at hand. I did this myself for two
of the conversion helper scripts. However, enough bitrot has now
occurred that to make the relationship murky. Since I had to adopt
them to the 80-column limit as well, I shaved all the irrelevant
differences away, and now they're just a small diff away from the
reformat script. I also added block comments to help developers find
where they need to edit the script. Since reformat_dat_files.pl has
been substantially altered, I'll attach it here, along with the diffs
to the the helper scripts.
I wrote:
> I’ll see about a new Makefile.
I've attached a draft of this. I thought about adding a call to
duplicate_oids here, but this won't run unless you've run configure
first, and if you've done that, you've likely built already, running
duplicate_oids in the process.
I think I'll consolidate all documentation patches into one, at the
end of the series for maximum flexibility. I liked the idea of
spreading the doc changes over the patches, but there is not a huge
amount of time left.
-John Naylor
| Attachment | Content-Type | Size |
|---|---|---|
| remove_pg_type_oid_symbols.diff | text/plain | 3.2 KB |
| convert_oid2name.diff | text/plain | 7.3 KB |
| v13alpha-reformat_dat_files.pl | application/x-perl | 7.3 KB |
| v13alpha-Makefile | application/octet-stream | 759 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-03-27 14:45:17 | Re: Foreign keys and partitioned tables |
| Previous Message | Yugo Nagata | 2018-03-27 14:28:04 | Re: [HACKERS] [PATCH] Lockable views |