From: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: unique indexes on partitioned tables |
Date: | 2018-02-19 18:16:47 |
Message-ID: | CAJGNTeMi58OomMrP_5svJH0oG1cJAkGha-3+FPO5Ba-thcXdEA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12 February 2018 at 15:26, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Hello,
>
> Thanks, Peter, Jesper, Amit, for reviewing the patch. Replying to
> all review comments at once:
>
[... v5 of patch attached ...]
Hi Álvaro,
attached a tiny patch (on top of yours) that silence two "variables
uninitilized" warnings.
also noted that if you:
"""
create table t1(i int) partition by hash (i);
create table t1_0 partition of t1 for values with (modulus 2, remainder 0);
create table t1_1 partition of t1 for values with (modulus 2, remainder 1);
create unique index on t1(i);
alter table t1 add primary key using index t1_i_idx ;
"""
the ALTER TABLE ADD PK does not recurse to partitions, which maybe is
perfectly fine because i'm using USING INDEX but it feels like an
oversight to me
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-fix-uninitilized-vaiables-uniq-indexes-on-partitioned-v5.patch | text/x-patch | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fabien COELHO | 2018-02-19 18:23:04 | pgbench - test whether a variable exists |
Previous Message | Fabien COELHO | 2018-02-19 17:27:51 | Re: pgbench - allow to specify scale as a size |