From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug fix for tab completion of ALTER TABLE ... VALIDATE CONSTRAINT ... |
Date: | 2021-04-27 09:33:25 |
Message-ID: | CAJ7c6TPjd5ARCdjabewO6mF13v9toMwv72+nc1fMERpkSY3qRQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi David,
> I noticed that $subject completes with already valid constraints,
> please find attached a patch that fixes it. I noticed that there are
> other places constraints can be validated, but didn't check whether
> similar bugs exist there yet.
There was a typo in the patch ("... and and not convalidated"). I've fixed
it. Otherwise the patch passes all the tests and works as expected:
eax=# create table foo (x int);
CREATE TABLE
eax=# alter table foo add constraint bar check (x < 3) not valid;
ALTER TABLE
eax=# alter table foo add constraint baz check (x <> 5) not valid;
ALTER TABLE
eax=# alter table foo validate constraint ba
bar baz
eax=# alter table foo validate constraint bar;
ALTER TABLE
--
Best regards,
Aleksander Alekseev
Attachment | Content-Type | Size |
---|---|---|
v2-0001-tab-completion-of-ALTER-TABLE.VALIDATE-CONSTRAINT.patch | application/octet-stream | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2021-04-27 09:40:49 | Re: TRUNCATE on foreign table |
Previous Message | vignesh C | 2021-04-27 08:16:55 | Re: [HACKERS] logical decoding of two-phase transactions |