From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Subject: | Re: Remove unused fields in ReorderBufferTupleBuf |
Date: | 2024-01-22 14:18:50 |
Message-ID: | CAJ7c6TOuqrD0ogZtfV4P7g_ugxKTQNgRPCUjnqonLf+YCeWmkg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
> > But why didn't you pursue your idea of getting rid of the wrapper
> > structure ReorderBufferTupleBuf which after this patch will have just
> > one member? I think there could be hassles in backpatching bug-fixes
> > in some cases but in the longer run it would make the code look clean.
>
> Indeed. In fact turned out that I suggested the same above but
> apparently forgot:
>
> > On top of that IMO it doesn't make much sense to keep a one-field
> > wrapper structure. Perhaps we should get rid of it entirely and just
> > use HeapTupleData instead.
>
> After actually trying the refactoring I agree that the code becomes
> cleaner and it's going to be beneficial in the long run. Here is the
> patch.
I did a mistake in v4:
```
- alloc_len = tuple_len + SizeofHeapTupleHeader;
+ alloc_len = tuple_len + HEAPTUPLESIZE;
```
Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Remove-ReorderBufferTupleBuf-structure.patch | application/octet-stream | 18.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-01-22 14:27:58 | Re: remaining sql/json patches |
Previous Message | Melih Mutlu | 2024-01-22 14:03:28 | Re: Improve WALRead() to suck data directly from WAL buffers when possible |