| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c) |
| Date: | 2021-07-15 13:01:15 |
| Message-ID: | CAJ7c6TNzgrah6EeDyoBoZ0TemMHG7OdJEuy9qCvavV-BXb7X9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks, David.
> I lost where. Can you show me?
See the attached warnings.txt.
> But the benchmark came from:
> pgbench -i -p 5432 -d postgres
> pgbench -c 50 -T 300 -S -n
I'm afraid this tells nothing unless you also provide the
configuration files and the hardware description, and also some
information on how you checked that there is no performance
degradation on all the other supported platforms and possible
configurations. Benchmarking is a very complicated topic - trust me,
been there!
It would be better to submit two separate patches, the one that
addresses Size_t and another that addresses shadowing. Refactorings
only, nothing else.
Regarding the code formatting, please see src/tools/pgindent.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| warnings.txt | text/plain | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2021-07-15 13:02:00 | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |
| Previous Message | Ranier Vilela | 2021-07-15 12:54:53 | Re: Signed vs Unsigned (take 2) (src/backend/storage/ipc/procarray.c) |