| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: Remove unused fields in ReorderBufferTupleBuf |
| Date: | 2023-07-26 13:52:14 |
| Message-ID: | CAJ7c6TNzLpK9uy0P0yqA8XesKd=Ai6sMtEzux_=oOV0L9yvT2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Here is the corrected patch. I added it to the nearest CF [1].
I played a bit more with the patch. There was an idea to make
ReorderBufferTupleBufData an opaque structure known only within
reorderbyffer.c but it turned out that replication/logical/decode.c
accesses it directly so I abandoned that idea for now.
> Alternatively we could convert ReorderBufferTupleBufData macro to an
> inlined function. At least it will add some type safety.
Here is v3 that implements it too as a separate patch.
Apologies for the noise.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Remove-unused-fields-in-ReorderBufferTupleBuf.patch | application/octet-stream | 1.9 KB |
| v3-0002-Replace-ReorderBufferTupleBufData-macro-with-a-fu.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-07-26 13:57:03 | Re: WaitForOlderSnapshots in DETACH PARTITION causes deadlocks |
| Previous Message | Alvaro Herrera | 2023-07-26 13:49:39 | Re: cataloguing NOT NULL constraints |