| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add crc32(text) & crc32(bytea) |
| Date: | 2024-08-05 13:19:45 |
| Message-ID: | CAJ7c6TNLbjr5tF11J6eKQOYGW3c_ztE_G8-BvmjU3QCJiSjLkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> I'm curious why we need to do this instead of only using the macros:
>
> INIT_TRADITIONAL_CRC32(crc);
> COMP_TRADITIONAL_CRC32(crc, VARDATA_ANY(in), len);
> FIN_TRADITIONAL_CRC32(crc);
>
> + * IDENTIFICATION
> + * src/backend/utils/adt/hashfuncs.c
>
> Perhaps these would fit into src/backend/utils/hash/pg_crc.c?
Thanks, PFA patch v3.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-crc32-bytea-crc32c-bytea.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-08-05 13:33:17 | Re: Detailed release notes |
| Previous Message | Tom Lane | 2024-08-05 13:14:49 | Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~? |