| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Subject: | Re: Postgres and --config-file option |
| Date: | 2024-01-15 11:35:27 |
| Message-ID: | CAJ7c6TN+KrXdiCkeQ6ZNL-VkRPS3VKw-t+Y6QNE+5EdwDUbVqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> It might be worthwhile to update the documentation if it would've helped
> prevent confusion here.
> Its documentation also describes this method of specifying parameters in
> the 'Examples' section.
I believe the documentation for 'postgres' already does a decent job
in describing what --NAME=VALUE means, and gives an example. IMO the
actual problem is with --help message and the specific error message.
> Please read the documentation for the complete list of run-time
> configuration settings and how to set them on the command line or in
> the configuration file
Additionally --help message doesn't tell which part of the
documentation should be read specifically. This being said, personally
I don't think that providing specific URLs in the --help message would
be a good idea. This would indicate that the --help message is just
written poorly.
> As for the help message, I’d minimally add:
>
> “You must specify the --config-file (or equivalent -c) or -D invocation …”
Good idea.
PFA the patch. It's short but I think it mitigates the problem.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Clarify-error-message-about-specifying-config-fil.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-01-15 12:03:51 | Re: Lockless exit path for ReplicationOriginExitCleanup |
| Previous Message | Jakub Wartak | 2024-01-15 10:54:07 | Re: Make NUM_XLOGINSERT_LOCKS configurable |