| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Patch: Cover POSITION(bytea,bytea) with tests |
| Date: | 2025-03-17 14:14:21 |
| Message-ID: | CAJ7c6TMHjxMaTq3o7tJH2SXXRkiakqXqWZMxwXyaHWpTAnQSrg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
> Some minor comments:
>
> 1. I thought the new test cases should be located earlier in the file
> where there were already a couple of POSITION tests.
> (see "-- E021-11 position expression")
>
> 2. Maybe one of your test cases can be identical to the example from
> the docs [1].
> position('\x5678'::bytea in '\x1234567890'::bytea) → 3
Thanks.
Here is the corrected patch.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Cover-POSITION-bytea-bytea-with-tests.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-03-17 14:23:56 | Re: Statistics Import and Export |
| Previous Message | Robert Haas | 2025-03-17 13:52:41 | Re: making EXPLAIN extensible |