| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-08-08 05:23:07 |
| Message-ID: | CAHv8Rj+v-TJ3RoZse87zyVPr-VhrOXDw55-3F3xF1+6WSJxaMA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 7, 2024 at 1:31 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham,
>
> Here are my review comments for patch v24-0001
>
> I think the TAP tests have incorrect expected results for the nogen-to-gen case.
>
> Whereas the HEAD code will cause "ERROR" for this test scenario, patch
> 0001 does not. IMO the behaviour should be unchanged for this scenario
> which has no generated column on the publisher side. So it seems this
> is a bug in patch 0001.
>
> FYI, I have included "FIXME" comments in the attached top-up diff
> patch to show which test cases I think are expecting wrong results.
>
Fixed all the comments. The attached Patch(v25-0001) contains all the changes.
Thanks and Regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0001-Enable-support-for-include_generated_columns-opt.patch | application/octet-stream | 106.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-08-08 05:38:48 | Re: Logical Replication of sequences |
| Previous Message | Pavel Stehule | 2024-08-08 05:17:00 | Re: proposal: schema variables |