From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_upgrade - typo in verbose log |
Date: | 2023-05-11 09:09:28 |
Message-ID: | CAHut+PtDSrtq1mPetoaSkHs0xWz+kPyWpmp8Qqz4rtC_hf71uQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 11, 2023 at 6:30 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 11 May 2023, at 07:41, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> > While reviewing another patch for the file info.c, I noticed some
> > misplaced colon (':') in the verbose logs for print_rel_infos().
>
> That spelling was introduced in c2e9b2f28818 which was the initial import of
> pg_upgrade into contrib/ for the 9.0 release (at that time the function was
> relarr_print() which via a few other names was renamed to print_rel_infos() in
> 0a5f1199319).
>
> It's not entirely clear to me if the current spelling is a mistake or
> intentional, but I do agree that your version is an improvement.
>
> To be consistent with other log output in pg_upgrade we should probably also
> wrap the relname and reltblspace in quotes as \"%s.%s\" and \"%s\" (and the
> Database in print_db_infos()).
>
Thanks for checking, and for the feedback.
PSA patch v2 updated as suggested.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v2-0001-pg_upgrade-typo-in-verbose-log.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey M. Borodin | 2023-05-11 09:36:37 | Re: psql tests hangs |
Previous Message | Hayato Kuroda (Fujitsu) | 2023-05-11 08:56:04 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |