| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-07-04 01:09:42 |
| Message-ID: | CAHut+Pt8q9hGA51VS2EoOw=HoHGR45c5A7Ps5fjVGL8cO9gTyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh. Here are my comments for the latest patch v20240703-0001.
======
doc/src/sgml/func.sgml
nitpick - /lsn/LSN/ (all other doc pages I found use uppercase for this acronym)
======
src/backend/commands/sequence.c
nitpick - /lsn/LSN/
======
Please see attached nitpicks diff.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| PS_NITPICKS_20240704_SEQ_0001.txt | text/plain | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-07-04 01:29:39 | Re: On disable_cost |
| Previous Message | Michael Paquier | 2024-07-04 00:51:16 | Re: Internal error codes triggered by tests |