| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add common function ReplicationOriginName. |
| Date: | 2022-09-26 03:15:08 |
| Message-ID: | CAHut+PsB9hEEU-JHqTUBL3bv--vesUvThYr1-95ZyG5PkF9PQQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 21, 2022 at 8:22 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
...
> > > On Wed, Sep 21, 2022 at 3:23 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > > ...
> > >
> > > > Can't we use the existing function ReplicationOriginNameForTablesync()
> > > > by passing relid as InvalidOid for this purpose? We need a check
> > > > inside to decide which name to construct, otherwise, it should be
> > > > fine. If we agree with this, then we can change the name of the
> > > > function to something like ReplicationOriginNameForLogicalRep or
> > > > ReplicationOriginNameForLogicalRepWorkers.
> > > >
...
>
> OK, I can unify the 2 functions as you suggested. I will post another
> patch in a few days.
>
PSA patch v3 to combine the different replication origin name
formatting in a single function ReplicationOriginNameForLogicalRep as
suggested.
------
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Add-common-function-ReplicationOriginNameForLogic.patch | application/octet-stream | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-09-26 04:22:00 | Re: Removing unused parameter in SnapBuildGetOrBuildSnapshot |
| Previous Message | wangw.fnst@fujitsu.com | 2022-09-26 03:11:38 | RE: Perform streaming logical transactions by background workers and parallel apply |