Re: row filtering for logical replication

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: row filtering for logical replication
Date: 2021-12-21 08:58:54
Message-ID: CAHut+Ps+dACvefCZasRE=P=DtaNmQvM3kiGyKyBHANA0yGcTZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is the v51* patch set:

Main changes from Euler's v50* are
1. Most of Euler's "fixes" patches are now merged back in
2. Patches are then merged per Amit's suggestion [Amit 20/12]
3. Some other review comments are addressed

~~

Phase 1 - Merge the Euler fixes
===============================

v51-0001 (main) <== v50-0001 (main 0001) + v50-0002 (fixes 0001)
- OK, accepted and merged all the "fixes" back into the 0001
- (fixed typos)
- There is a slight disagreement with what the PG docs say about
NULLs, but I will raise a separate comment on -hackers later
(meanwhile, the current PG docs text is from the Euler patch)

v51-0002 (validation) <== v50-0003 (validation 0002) + v50-0004 (fixes 0002)
- OK, accepted and merges all these "fixes" back into the 0002
- (fixed typo)

v51-0003 (new/old) <== v50-0005 (new/old 0003)
- REVERTED to the v49 version of this patch!
- Please see Ajin's explanation why the v49 code was required [Ajin 21/12]

v51-0004 (tab-complete + dump) <== v50-0006 (tab-complete + dump 0004)
- No changes

v51-0005 (for all tables) <== v50-0007 (for all tables 0005) +
v50-0008 (fixes 0005)
- OK, accepted and merged most of these "fixes" back into the 0005
- (fixed typo/grammar)
- Amit requested we not use Euler's new tablesync SQL just yet [Amit 21/12]

Phase 2 - Merge main (Phase 1) patches per Amit suggestion
================================================

v51-0001 (main) <== v51-0001 (main) + v51-0002 (validation) + v51-0005
(for all tables)
- (also combined all the commit comments)

v51-0002 (new/old) <== v51-0003 (new/old)

v51-0005 (tab-complete + dump) <== v51-0004

Review comments (details)
=========================

v51-0001 (main)
- Addressed review comments from Amit. [Amit 20/12] #1,#2,#3,#4

v51-0002 (new/old tuple)
- Includes a patch from Greg (provided internally)

v51-0003 (tab, dump)
- No changes

------
[Amit 20/12] https://www.postgresql.org/message-id/CAA4eK1JJgfEPKYvQAcwGa5jjuiUiQRQZ0Pgo-HF0KFHh-jyNQQ%40mail.gmail.com
[Ajin 21/12] https://www.postgresql.org/message-id/CAFPTHDbfpPNh3GLGjySS%3DAuRfbQPQFNvfiyG1GDQW2kz1yT7Og%40mail.gmail.com
[Amit 21/12] https://www.postgresql.org/message-id/CAA4eK1KwoA5k8v9z9e4ZPN_X%3D1GAmQmsWyauFwZpKiSHqy6eZA%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v51-0003-Row-filter-tab-auto-complete-and-pgdump.patch application/octet-stream 5.6 KB
v51-0002-Row-filter-updates-based-on-old-new-tuples.patch application/octet-stream 21.5 KB
v51-0001-Row-filter-for-logical-replication.patch application/octet-stream 132.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Nancarrow 2021-12-21 08:59:34 Re: Failed transaction statistics to measure the logical replication progress
Previous Message Zhihong Yu 2021-12-21 08:56:06 Re: simplifying foreign key/RI checks