| From: | Peter Moser <pitiz29a(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Johann Gamper <gamper(at)inf(dot)unibz(dot)it>, Michael Böhlen <boehlen(at)ifi(dot)uzh(dot)ch>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Anton Dignös <anton(dot)dignoes(at)unibz(dot)it> |
| Subject: | Re: [PROPOSAL] Temporal query processing with range types |
| Date: | 2017-09-13 12:57:47 |
| Message-ID: | CAHO0eLaxh+teOv31yCA567p6to3+D73gNghu7Zg9WFz3hW+gRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
2017-09-01 6:49 GMT+02:00 Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>:
> On Tue, Aug 1, 2017 at 12:53 AM, Peter Moser <pitiz29a(at)gmail(dot)com> wrote:
> This patch still applies, but no longer compiles:
>
> nodeTemporalAdjustment.c: In function ‘ExecTemporalAdjustment’:
> nodeTemporalAdjustment.c:286:21: error: incompatible types when
> assigning to type ‘Form_pg_attribute’ from type
> ‘FormData_pg_attribute’
> node->datumFormat = curr->tts_tupleDescriptor->attrs[tc->attNumP1 - 1];
> ^
>
> After commits 2cd70845 and c6293249 you need to change expressions of
> that format to, for example:
>
> node->datumFormat = TupleDescAttr(curr->tts_tupleDescriptor,
> tc->attNumP1 - 1);
Hi Thomas,
thank you for your feedback.
We fixed the mentioned issues and rebased our patch on top of commit
69835bc8988812c960f4ed5aeee86b62ac73602a from "Tue Sep 12 19:27:48
2017 -0400".
Best regards,
Anton, Johann, Michael, Peter
| Attachment | Content-Type | Size |
|---|---|---|
| tpg_primitives_out_v8.patch | text/x-patch | 137.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-09-13 13:01:55 | Re: Hooks to track changed pages for backup purposes |
| Previous Message | Andrey Borodin | 2017-09-13 12:56:05 | Re: Hooks to track changed pages for backup purposes |