Re: row filtering for logical replication

From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Suzuki Hironobu <hironobu(at)interdb(dot)jp>, a(dot)kondratov(at)postgrespro(dot)ru
Subject: Re: row filtering for logical replication
Date: 2019-09-01 00:28:16
Message-ID: CAHE3wgga+Z4PkzN4FgR5pO_y4Mn30mRcjfno5aXbnQE9YniEkw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em dom, 3 de fev de 2019 às 07:14, Andres Freund <andres(at)anarazel(dot)de> escreveu:
>
> As far as I can tell, the patch has not been refreshed since. So I'm
> marking this as returned with feedback for now. Please resubmit once
> ready.
>
I fix all of the bugs pointed in this thread. I decide to disallow
UDFs in filters (it is safer for a first version). We can add this
functionality later. However, I'll check if allow "safe" functions
(aka builtin functions) are ok. I add more docs explaining that
expressions are executed with the role used for replication connection
and also that columns used in expressions must be part of PK or
REPLICA IDENTITY. I add regression tests.

Comments?

--
Euler Taveira Timbira -
http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment Content-Type Size
0001-Remove-unused-atttypmod-column-from-initial-table-sy.patch text/x-patch 2.1 KB
0003-Refactor-function-create_estate_for_relation.patch text/x-patch 2.5 KB
0004-Rename-a-WHERE-node.patch text/x-patch 1.7 KB
0002-Store-number-of-tuples-in-WalRcvExecResult.patch text/x-patch 3.1 KB
0005-Row-filtering-for-logical-replication.patch text/x-patch 48.7 KB
0007-Publication-where-condition-support-for-pg_dump.patch text/x-patch 2.8 KB
0006-Print-publication-WHERE-condition-in-psql.patch text/x-patch 1.2 KB
0008-Debug-for-row-filtering.patch text/x-patch 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2019-09-01 00:31:52 Re: row filtering for logical replication
Previous Message Noah Misch 2019-08-31 22:30:26 Re: [HACKERS] Deadlock in XLogInsert at AIX