From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | "Syed, Rahila" <Rahila(dot)Syed(at)nttdata(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
Date: | 2014-11-28 04:30:44 |
Message-ID: | CAH2L28uL+iHvYjHaM+0R1QEcewp_RB7Dzipf5Q1QnZm8zmDP_w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> if (!fullPageWrites)
> {
> WALInsertLockAcquireExclusive();
> Insert->fullPageWrites = fullPageWrites;
> WALInsertLockRelease();
> }
>
As fullPageWrites is not a boolean isnt it better to change the if
condition as fullPageWrites == FULL_PAGE_WRITES_OFF? As it is done in the
if condition above, this seems to be a miss.
>doPageWrites = (Insert->fullPageWrites || Insert->forcePageWrites);
IIUC, doPageWrites is true when fullPageWrites is either 'on' or
'compress'
Considering Insert -> fullPageWrites is an int now, I think its better to
explicitly write the above as ,
doPageWrites = (Insert -> fullPageWrites != FULL_PAGE_WRITES_OFF ||
Insert->forcePageWrites)
The patch attached has the above changes. Also, it initializes
doPageCompression in InitXLOGAccess as per earlier discussion.
I have attached the changes separately as changes.patch.
Thank you,
Rahila Syed
Attachment | Content-Type | Size |
---|---|---|
changes.patch | application/octet-stream | 1.8 KB |
0002-Support-compression-for-full-page-writes-in-WAL.patch | application/octet-stream | 32.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ian Barwick | 2014-11-28 04:43:36 | Testing DDL deparsing support |
Previous Message | Amit Kapila | 2014-11-28 03:43:11 | Re: why is PG_AUTOCONF_FILENAME is pg_config_manual.h? |