| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element |
| Date: | 2024-12-27 22:03:12 |
| Message-ID: | CAH2-WzmWXjXQFDcwAYUBUH43838BxY+MUOy9-Nw1zTzw94o5WA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 23, 2024 at 1:02 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> Attached patch fixes the problem by moving detection of RowCompare
> unsatisfiable-due-to-NULL cases into _bt_fix_scankey_strategy.
Attached is v2, which adds several new regression tests, giving
certain relevant nbtree code paths test coverage.
v2 also makes some small tweaks to _bt_check_rowcompare(), the actual
comparator used by scans with a RowCompare qual. We no longer need to
account for the possibility that the first row member from a
RowCompare scan key contains a null once the scan is underway (we know
that _bt_preprocess_keys would have recognized the qual as
unsatisfiable had the RowCompare looked like that).
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Improve-nbtree-unsatisfiable-RowCompare-detection.patch | application/octet-stream | 14.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2024-12-28 00:15:59 | Re: [PATCHES] Post-special page storage TDE support |
| Previous Message | David E. Wheeler | 2024-12-27 22:02:56 | Re: Add Postgres module info |