| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve readability by using designated initializers when possible |
| Date: | 2024-02-27 16:06:47 |
| Message-ID: | CAGECzQQo0uQBN=vWCOnTdW3t95ckqm1e+ARCHVrs9V5a-s-bzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 27 Feb 2024 at 16:04, Japin Li <japinli(at)hotmail(dot)com> wrote:
> I see the config_group_names[] needs null-terminated because of help_config,
> however, I didn't find the reference in help_config.c. Is this comment
> outdated?
Yeah, you're correct. That comment has been outdated for more than 20
years. The commit that made it unnecessary to null-terminate the array
was 9d77708d83ee.
Attached is v5 of the patchset that also includes this change (with
you listed as author).
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0002-Use-designated-initializer-syntax-to-improve-read.patch | text/x-patch | 34.3 KB |
| v5-0003-Simplify-pg_enc2gettext_tbl.patch | text/x-patch | 4.7 KB |
| v5-0004-Remove-unnecessary-NULL-termination-in-config_gro.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-02-27 16:17:11 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |
| Previous Message | Alvaro Herrera | 2024-02-27 16:03:12 | Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock |