From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Calculation of param_source_rels in add_paths_to_joinrel |
Date: | 2016-11-24 04:17:39 |
Message-ID: | CAFjFpRfFfcLosbKpxv7Z+v=+nJuEhRrKnODxMJBWUWvnOgNYWw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks Tom.
On Thu, Nov 24, 2016 at 2:58 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
>> On Sat, Nov 5, 2016 at 2:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> writes:
>>>> Also, the way this code has been written, the declaration of variable
>>>> sjinfo masks the earlier declaration with the same name.
>
>>> Hmm, yeah, that's probably not terribly good coding practice.
>
>> Attached a patch to fix this.
>
> Pushed, sorry about the delay.
>
> regards, tom lane
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2016-11-24 04:52:46 | Re: patch: function xmltable |
Previous Message | Jim Nasby | 2016-11-24 03:53:36 | References to arbitrary database objects that are suitable for pg_dump |