From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: New CORRESPONDING clause design |
Date: | 2017-03-15 09:43:14 |
Message-ID: | CAFj8pRDURNQcMwgf=G0wqNRJQk-2fgwf8eJdNCzpYqa1WLafjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
2017-03-14 16:33 GMT+01:00 Surafel Temesgen <surafel3000(at)gmail(dot)com>:
>
> hi
>
> Some errors are related to just CORRESPONDING without any columns. So
>> using expr doesn't help here. So parse node CORRESPONDING can solve both
>> issues.
>>
> In current implementation pointing to a node means pointing to a node’s
> first element so I don’t think we can be able to point to CORRESPONDING
> without any columns
>
> I find out that there is already a node prepare for the case called
> A_Const.
> The attached patch use that node
>
It looks better
I fixed format of comments and some too long lines.
all regress tests passed
I have not any objection - I'll mark this patch as ready for commiter
Regards
Pavel
>
> Regards
> Surafel
>
Attachment | Content-Type | Size |
---|---|---|
corresponding_clause_v6.patch | text/x-patch | 59.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yugo Nagata | 2017-03-15 10:09:10 | Re: Report the number of skipped frozen pages by manual VACUUM |
Previous Message | Aleksander Alekseev | 2017-03-15 09:04:11 | Re: [PATCH] Suppress Clang 3.9 warnings |