From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ryan Lambert <ryan(at)rustprooflabs(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Anthony Nowocien <anowocien(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
Subject: | Re: dropdb --force |
Date: | 2019-11-18 12:59:23 |
Message-ID: | CAFj8pRD5zhyP9qvwE7E9LSE5sNaeBhK_y=7KPJQbd=1CGyE-2Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
po 18. 11. 2019 v 7:39 odesílatel Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
napsal:
>
>
> po 18. 11. 2019 v 7:37 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> napsal:
>
>> On Mon, Nov 18, 2019 at 10:59 AM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
>> wrote:
>> > po 18. 11. 2019 v 6:24 odesílatel Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
>> napsal:
>> >>
>> >> On Mon, Nov 18, 2019 at 10:33 AM Pavel Stehule <
>> pavel(dot)stehule(at)gmail(dot)com> wrote:
>> >> >
>> >> > po 18. 11. 2019 v 4:43 odesílatel vignesh C <vignesh21(at)gmail(dot)com>
>> napsal:
>> >> >>
>> >> >>
>> >> >> I had seen that isolation test(src/test/isolation) has a framework
>> to
>> >> >> support this. You can have a look to see if it can be handled using
>> >> >> that.
>> >> >
>> >> >
>> >> > I'll look there
>> >> >
>> >>
>> >> If we want to have a test for this, then you might want to look at
>> >> test src/test/recovery/t/013_crash_restart. In that test, we keep a
>> >> connection open and then validate whether it is terminated. Having
>> >> said that, I think it might be better to add this as a separate test
>> >> patch apart from main patch because it is a bit of a timing-dependent
>> >> test and might fail on some slow machines. We can always revert this
>> >> if it turns out to be an unstable test.
>> >
>> >
>> > +1
>> >
>>
>> So, are you planning to give it a try? I think even if we want to
>> commit this separately, it is better to have a test for this before we
>> commit.
>>
>
> I'll send this test today
>
here is it
Regards
Pavel
>
> Pavel
>
>
>>
>> --
>> With Regards,
>> Amit Kapila.
>> EnterpriseDB: http://www.enterprisedb.com
>>
>
Attachment | Content-Type | Size |
---|---|---|
dropdb-force2.patch | text/x-patch | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Khandekar | 2019-11-18 12:59:43 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
Previous Message | Michael Paquier | 2019-11-18 12:58:00 | Re: 'Invalid lp' during heap_xlog_delete |