From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Schema variables - new implementation for Postgres 15 |
Date: | 2022-04-10 18:30:39 |
Message-ID: | CAFj8pRCeu_Aku3mHqS6vDL1p02u1Ed5QiOGL3e4CPKyvkW6s3Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
čt 3. 3. 2022 v 8:16 odesílatel Julien Rouhaud <rjuju123(at)gmail(dot)com> napsal:
> On Thu, Mar 03, 2022 at 03:06:52PM +0800, Julien Rouhaud wrote:
> > Hi,
> >
> > On Wed, Mar 02, 2022 at 06:03:06AM +0100, Pavel Stehule wrote:
> > >
> > > I lost commit with this change. I am sending updated patch.
>
> Also, another thing is the size of the patch. It's probably the minimum to
> have a consistent working implementation, but maybe we can still split it
> to
> make review easier?
>
> For instance, maybe having:
>
> - the pg_variable part on its own, without a way to use them, maybe with
> syscache helpers
> - the main session variable implementation and test coverage
> - plpgsql support and test coverage
> - pg_dump support and test coverage
>
> It wouldn't make the main patch that small but could still help quite a
> bit.
>
> Any better suggestion?
>
I am sending fresh rebased patch + separation to more patches. This split
is initial, and can be changed later
Regards
Pavel
Attachment | Content-Type | Size |
---|---|---|
v20220410-0011-documentation.patch | text/x-patch | 43.0 KB |
v20220410-0010-This-patch-changes-error-message-column-doesn-t-exis.patch | text/x-patch | 29.2 KB |
v20220410-0007-Enhancing-psql-for-session-variables.patch | text/x-patch | 15.1 KB |
v20220410-0009-Regress-tests-for-session-variables.patch | text/x-patch | 32.0 KB |
v20220410-0008-typedefs.patch | text/x-patch | 1.6 KB |
v20220410-0006-Support-of-LET-command-in-PLpgSQL.patch | text/x-patch | 11.5 KB |
v20220410-0005-LET-command.patch | text/x-patch | 40.4 KB |
v20220410-0004-DISCARD-VARIABLES-command.patch | text/x-patch | 3.2 KB |
v20220410-0003-session-variables.patch | text/x-patch | 94.1 KB |
v20220410-0002-Possibility-to-dump-session-variables-by-pg_dump.patch | text/x-patch | 19.4 KB |
v20220410-0001-Catalogue-support-for-session-variables.patch | text/x-patch | 80.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Samuel Bassaly | 2022-04-10 18:52:55 | GSoC: pgBackRest port to Windows |
Previous Message | Simon Riggs | 2022-04-10 18:18:10 | Re: suboverflowed subtransactions concurrency performance optimize |