From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Catalin Iacob <iacobcatalin(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, dinesh kumar <dineshkumar02(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: multiple psql option -c |
Date: | 2015-12-01 02:46:30 |
Message-ID: | CAFj8pRCK7OLdrV3H3j2zaUQTb8NDc4GuDDzqfcOREAHyigkPWw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2015-11-30 15:17 GMT+01:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:
> On Thu, Nov 26, 2015 at 4:21 AM, Pavel Stehule wrote:
> > Attached patch per Tom Lane proposal.
> >
> > * multiple -c -f options are supported, the order of options is respected
> > * the statements for one -c options are executed in transactions
> > * Iacob's doc patch merged
>
> enum _actions
> {
> ACT_NOTHING = 0,
> - ACT_SINGLE_SLASH,
> ACT_LIST_DB,
> - ACT_SINGLE_QUERY,
> - ACT_FILE
> + ACT_FILE_STDIN
> };
>
> Removing some items from the list of potential actions and creating a
> new sublist listing action types is a bit weird. Why not grouping them
> together and allow for example -l as well in the list of things that
> is considered as a repeatable action? It seems to me that we could
> simplify the code this way, and instead of ACT_NOTHING we could check
> if the list of actions is empty or not.
>
fixed
Regards
Pavel
> --
> Michael
>
Attachment | Content-Type | Size |
---|---|---|
psql-group-command-08.patch | text/x-patch | 24.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2015-12-01 02:53:35 | Re: Error with index on unlogged table |
Previous Message | Kyotaro HORIGUCHI | 2015-12-01 02:11:01 | Re: Error with index on unlogged table |