| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |
| Date: | 2021-07-22 16:17:01 |
| Message-ID: | CAFj8pRC9pGr2C+vNUb_zaL-csYQDRdrAjnh65m=d=OX=X3jiGg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
čt 22. 7. 2021 v 14:54 odesílatel Aleksander Alekseev <
aleksander(at)timescale(dot)com> napsal:
> Hi Pavel,
>
> >> I am sending an enhanced patch about the regress test for plpgsql's
> debug API.
>
> Thanks for the test! I noticed some little issues with formatting and
> typos. The corrected patch is attached.
>
> > override CPPFLAGS := $(CPPFLAGS) -I$(top_srcdir)/src/pl/plpgsql/src
>
> You probably already noticed, but for the record - AppVeyor doesn't seem
> to be happy still [1]:
>
> ```
> src/test/modules/test_dbgapi/test_dbgapi.c(17): fatal error C1083: Cannot
> open include file: 'plpgsql.h': No such file or directory
> [C:\projects\postgresql\test_dbgapi.vcxproj]
>
```
>
> [1]:
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.141500
>
I know it. Attached patch try to fix this issue
I merged you patch (thank you)
Regards
Pavel
>
> --
> Best regards,
> Aleksander Alekseev
>
| Attachment | Content-Type | Size |
|---|---|---|
| enhancing-plpgsql-dbgapi-20210722.patch | text/x-patch | 39.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-07-22 16:18:51 | Re: pg_amcheck: Fix block number parsing on command line |
| Previous Message | Dean Rasheed | 2021-07-22 16:06:55 | Re: WIP: Relaxing the constraints on numeric scale |