From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Chapman Flack <chap(at)anastigmatix(dot)net> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: proposal: variadic argument support for least, greatest function |
Date: | 2019-02-12 08:15:34 |
Message-ID: | CAFj8pRC2Zh90OWwLR=TtNsAVYXLoPCh-r_ttU5L2cpYLjmg7eg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
út 12. 2. 2019 v 2:00 odesílatel Chapman Flack <chap(at)anastigmatix(dot)net>
napsal:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: not tested
> Spec compliant: not tested
> Documentation: not tested
>
> The argument for consistency with other functions that are variadic makes
> sense to me: although they are different from ordinary variadic functions
> in the type unification they do, their description in the manual simply
> calls them functions without calling attention to any way that they are
> different beasts. So, a reader might reasonably be surprised that VARIADIC
> doesn't work in the usual way.
>
> This patch applies (with some offsets) but the build produces several
> incompatible pointer type assignment warnings, and fails on errors where
> fcinfo->arg is no longer a thing (so should be rebased over the
> variable-length function call args patch).
>
> It does not yet add regression tests, or update the documentation in
> func.sgml.
here is fixed patch
Regards
Pavel
Attachment | Content-Type | Size |
---|---|---|
minmax_variadic-20190212.patch | text/x-patch | 11.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Arthur Zakirov | 2019-02-12 08:44:14 | Re: [PATCH] xlogreader: do not read a file block twice |
Previous Message | Tsunakawa, Takayuki | 2019-02-12 07:51:41 | RE: Commit Fest 2019-01 is now closed |