From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Sergei Kornilov <sk(at)zsrv(dot)org>, Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
Subject: | Re: [HACKERS] generated columns |
Date: | 2019-03-26 18:52:24 |
Message-ID: | CAFj8pRBaDqM4xEQTXFDb--i=UDRwXPuPD38mpmD7XFrJubJR8w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi
út 26. 3. 2019 v 14:33 odesílatel Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> napsal:
> On 2019-03-20 03:51, Michael Paquier wrote:
> > On Mon, Mar 18, 2019 at 03:14:09PM +0100, Pavel Stehule wrote:
> >> postgres=# update foo set name = 'bbbxx' where id = 1; -- error
> >> ERROR: no generation expression found for column number 3 of table
> >> "foo"
> >
> > Yes I can see the problem after adding a generated column and dropping
> > it on an INSERT query.
>
> fixed
>
> > + if (relid && attnum && get_attgenerated(relid, attnum))
> > Better to use OidIsValid here?
>
> fixed
>
> > + (walrcv_server_version(wrconn) >= 120000 ? "AND a.attgenerated =
> ''" : ""),
> > I think that it is better to always have version-related references
> > stored as defines.
>
> A valid idea, but I don't see it widely done (see psql, pg_dump).
>
> > +CREATE TABLE gtest22a (a int PRIMARY KEY, b int GENERATED ALWAYS AS (a
> * 2) STORED UNIQUE);
> > +CREATE TABLE gtest22b (a int, b int GENERATED ALWAYS AS (a * 2) STORED,
> PRIMARY KEY (a, b));
> > Some tests for unique constraints with a generated column should be in
> > place?
>
> done
>
> > It would be nice to have extra tests for forbidden expression types
> > on generated columns especially SRF, subquery and aggregates/window
> > functions.
>
> done
>
make check-world fails
regards
Pavel
> --
> Peter Eisentraut http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>
Attachment | Content-Type | Size |
---|---|---|
regression.diffs | application/octet-stream | 2.3 KB |
dblink.out | application/octet-stream | 31.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Kukshiev | 2019-03-26 18:59:24 | Fwd: Gsoc proposal perffarn |
Previous Message | Tom Lane | 2019-03-26 18:25:52 | Re: pgsql: Get rid of backtracking in jsonpath_scan.l |