From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: unescape_text function |
Date: | 2020-07-02 17:09:57 |
Message-ID: | CAFj8pRAkYbLUCc9QBw64LP4NaP-qCmGm3EpU+zyh=BgwZpf_BQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
čt 2. 7. 2020 v 17:27 odesílatel Daniel Gustafsson <daniel(at)yesql(dot)se> napsal:
> > On 23 Jun 2020, at 11:51, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> > I changed the name to more accurately "unicode_unescape". Patch is
> assigned
>
> You've made this function return Oid, where it used to be void. Was that a
> copy-paste mistake? Else the code needs fixing as it doesn't return an Oid.
>
> +Oid
> +check_unicode_value(pg_wchar c)
> +{
> + if (!is_valid_unicode_codepoint(c))
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("invalid Unicode escape value")));
> +}
>
>
yes, it is my error
I am sending fixed patch
Thank you for check
Pavel
cheers ./daniel
>
Attachment | Content-Type | Size |
---|---|---|
unicode_uescape-20200702.patch | text/x-patch | 10.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2020-07-02 17:11:53 | Re: Using Valgrind to detect faulty buffer accesses (no pin or buffer content lock held) |
Previous Message | Tom Lane | 2020-07-02 16:51:24 | Re: cannot restore schema with is not distinct from on hstore since PG 9.6.8 |