From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Alexander Kumenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Proposal: Improve bitmap costing for lossy pages |
Date: | 2017-10-06 14:04:16 |
Message-ID: | CAFiTN-uDeuUxbJfwQXNYNWLh_Qivexc-N+udptjT3R-ujEpZgg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 6, 2017 at 7:04 PM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Fri, Oct 6, 2017 at 6:36 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Oct 6, 2017 at 2:12 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>>>> The performance results look good, but that's a slightly different
>>>> thing from whether the estimate is accurate.
>>>>
>>>> + nbuckets = tbm_calculate_entires(maxbytes);
>>>>
>>>> entires?
>>>
>>> changed to
>>> + tbm->maxentries = (int) tbm_calculate_entires(maxbytes);
>>
>> My point was not that you should add a cast, but that you wrote
>> "entires" rather than "entries".
>
> My bad, I thought you were suggesting the variable name as "entries"
> instead of "nbuckets" so I removed the variable "nbuckets". I will
> fix the typo in the function name and post the patch.
Fixed in the attached version.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
improve_bitmap_cost_v5.patch | application/octet-stream | 3.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-10-06 14:06:38 | Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
Previous Message | Alvaro Herrera | 2017-10-06 13:57:12 | Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |