Re: Undo logs

On Wed, Jan 9, 2019 at 11:40 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:

> On Tue, Jan 8, 2019 at 2:11 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
>
>>
>>
>> 3.
>> + work_txn.urec_next = uur->uur_next;
>> + work_txn.urec_xidepoch = uur->uur_xidepoch;
>> + work_txn.urec_progress = uur->uur_progress;
>> + work_txn.urec_prevurp = uur->uur_prevurp;
>> + work_txn.urec_dbid = uur->uur_dbid;
>>
>> It would be better if we initialize these members in the order in
>> which they appear in the actual structure. All other undo header
>> structures are initialized that way, so this looks out-of-place.
>
>
One more change in ReadUndoByte on same line.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com