From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: POC: Cleaning up orphaned files using undo logs |
Date: | 2019-07-06 14:56:29 |
Message-ID: | CAFiTN-tZKP5B7JeDX7tKQ+Wkonwktg0S+7CTgHnw=fL5-8VE2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jul 4, 2019 at 5:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
PFA, the latest version of the undo interface and undo processing patches.
Summary of the changes in the patch set
1. Undo Interface
- Rebased over latest undo storage code
- Implemented undo page compression (don't store the common fields in
all the records instead we get from the first complete record of the
page).
- As per Robert's comment, UnpackedUndoRecord is divided in two parts,
a) All fields which are set by the caller.
b) Pointer to structures which are set internally.
- Epoch and the Transaction id are unified as full transaction id
- Fixed handling of dbid during recovery (TODO in PrepareUndoInsert)
Pending:
- Move loop in UndoFetchRecord to outside and test performance with
keeping pin vs pin+lock across undo records. This will be done after
testing performance over the zheap code.
- I need to investigate whether Discard checking can be unified in
master and HotStandby in UndoFetchRecord function.
2. Undo Processing
- Defect fix in multi-log rollback for subtransaction.
- Assorted defect fixes.
Others
- Fixup for undo log code to handle full transaction id in
UndoLogSlot for discard and other bug fixes in undo log.
- Fixup for Orphan file cleanup to pass dbid in PrepareUndoInsert
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
undo_20190706.tar.gz | application/x-gzip | 90.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2019-07-06 15:23:37 | Re: Optimize partial TOAST decompression |
Previous Message | Tom Lane | 2019-07-06 14:11:34 | Re: Use relative rpath if possible |