Re: Make relfile tombstone files conditional on WAL level

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make relfile tombstone files conditional on WAL level
Date: 2022-01-31 05:29:33
Message-ID: CAFiTN-sFGRBYLf1RqsNKWVv=6XmJwOYqiYbBp6wsKegYEHcriQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 28, 2022 at 8:10 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Wed, Jan 19, 2022 at 10:37 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >

>
> TODO:
>
> There are a couple of TODOs and FIXMEs which I am planning to improve
> by next week. I am also planning to do the testing where relfilenode
> consumes more than 32 bits, maybe for that we can set the
> FirstNormalRelfileNode to higher value for the testing purpose. And,
> Improve comments.
>

I have fixed most of TODO and FIXMEs but there are still a few which I
could not decide, the main one currently we do not have uint8 data
type only int8 is there so I have used int8 for storing relfilenode +
forknumber. Although this is sufficient because I don't think we will
ever get more than 128 fork numbers. But my question is should we
think for adding uint8 as new data type or infect make RelNode itself
as new data type like we have Oid.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v2-WIP-0001-Don-t-delay-removing-Tombstone-file-until-next-ch.patch text/x-patch 114.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-01-31 05:31:58 Re: Error "initial slot snapshot too large" in create replication slot
Previous Message Bharath Rupireddy 2022-01-31 05:28:31 Re: Is there a way (except from server logs) to know the kind of on-going/last checkpoint?