| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: making relfilenodes 56 bits |
| Date: | 2022-07-26 08:01:38 |
| Message-ID: | CAFiTN-s7M7n1PnDuONNjH68k-puFDLOdWD6TA_sE9wRjcgrLFQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 21, 2022 at 9:53 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Wed, Jul 20, 2022 at 11:27 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > [v10 patch set]
>
> Hi Dilip, I'm experimenting with these patches and will hopefully have
> more to say soon, but I just wanted to point out that this builds with
> warnings and failed on 3/4 of the CI OSes on cfbot's last run. Maybe
> there is the good kind of uninitialised data on Linux, and the bad
> kind of uninitialised data on those other pesky systems?
Here is the patch to fix the issue, basically, while asserting for the
file existence it was not setting the relfilenumber in the
relfilelocator before generating the path so it was just checking for
the existence of the random path so it was asserting randomly.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Convert-buf_internal.h-macros-to-static-inline-f.patch | text/x-patch | 12.2 KB |
| v11-0002-Preliminary-refactoring-for-supporting-larger-re.patch | text/x-patch | 23.1 KB |
| v11-0003-Remove-the-restriction-that-the-relmap-must-be-5.patch | text/x-patch | 8.4 KB |
| v11-0004-Widen-relfilenumber-from-32-bits-to-56-bits.patch | text/x-patch | 104.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shiy.fnst@fujitsu.com | 2022-07-26 08:05:05 | RE: Handle infinite recursion in logical replication setup |
| Previous Message | Masahiko Sawada | 2022-07-26 07:51:33 | Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns |