| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Conflict Detection and Resolution |
| Date: | 2024-09-06 08:35:14 |
| Message-ID: | CAFPTHDb1fMGCbkxtfp1Hck7sFMjd923BiqXgyqA5A84UVp8M0g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 29, 2024 at 2:50 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> On Wed, Aug 28, 2024 at 4:07 PM shveta malik <shveta(dot)malik(at)gmail(dot)com>
> wrote:
> >
> > > On Wed, Aug 28, 2024 at 10:30 AM Ajin Cherian <itsajin(at)gmail(dot)com>
> wrote:
> > > >
> >
> > The review is WIP. Please find a few comments on patch001.
> >
>
> More comments on ptach001 in continuation of previous comments:
>
>
Thank you for your feedback, Shveta. I've addressed both sets of comments
you provided. Additionally, I've revised the logic for how `pg_dump`
retrieves conflict resolver information and implemented a smarter approach
to avoid including default resolvers in the `CREATE SUBSCRIPTION` command.
To achieve this, I had to duplicate some of the conflict resolver
definitions in the `pg_dump.h` header, as including `conflict.h` directly
introduced too many dependencies with other headers.
Thanks to Nisha for separating 004 patch into two - 004(last_update_wins)
and 005(clock-skew).
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0005-Implements-Clock-skew-management-between-nodes.patch | application/octet-stream | 16.5 KB |
| v12-0004-Implements-last_update_wins-conflict-resolver.patch | application/octet-stream | 31.3 KB |
| v12-0003-Conflict-resolution-for-update_exists-conflict-t.patch | application/octet-stream | 15.6 KB |
| v12-0002-Conflict-resolvers-for-insert-update-and-delete.patch | application/octet-stream | 60.1 KB |
| v12-0001-Add-CONFLICT-RESOLVERS-into-the-syntax-for-CREAT.patch | application/octet-stream | 69.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-09-06 09:00:00 | Re: On disable_cost |
| Previous Message | Antonin Houska | 2024-09-06 08:08:35 | Re: why there is not VACUUM FULL CONCURRENTLY? |