From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2020-10-15 10:31:29 |
Message-ID: | CAFPTHDYs4=gkcNePQBNiQAO9gRmLJ9WvhgY3_N=-+s2wbd9DCg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 15, 2020 at 2:16 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Oct 14, 2020 at 6:15 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
>
> I think it will be easier to review this work if we can split the
> patches according to the changes made in different layers. The first
> patch could be changes made in output plugin and the corresponding
> changes in test_decoding, see the similar commit of in-progress
> transactions [1]. So you need to move corresponding changes from
> v8-0001-Support-decoding-of-two-phase-transactions and
> v8-0004-Support-two-phase-commits-in-streaming-mode-in-lo for this.
> The second patch could be changes made in ReorderBuffer to support
> this feature, see [2]. The third patch could be changes made to
> support pgoutput and subscriber-side stuff, see [3]. What do you
> think?
I agree. I have split the patches accordingly. Do have a look.
Pending work is:
1. Add pgoutput support for the new streaming two-phase commit APIs
2. Add test cases for two-phase commits with streaming for pub/sub and
test_decoding
3. Add CREATE SUBSCRIPTION command option to specify two-phase commits
rather than having it turned on by default.
regards,
Ajin Cherian
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v9-0001-Support-decoding-of-two-phase-transactions.patch | application/octet-stream | 48.9 KB |
v9-0003-pgoutput-plugin-support-for-logical-decoding-of-t.patch | application/octet-stream | 21.6 KB |
v9-0002-Backend-support-for-logical-decoding-of-two-phase.patch | application/octet-stream | 45.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-10-15 10:49:32 | Re: New statistics for tuning WAL buffer size |
Previous Message | Amit Kapila | 2020-10-15 09:48:45 | Re: Parallel Inserts in CREATE TABLE AS |