Re: Tying an object's ownership to datdba

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tying an object's ownership to datdba
Date: 2021-03-25 13:55:57
Message-ID: CAFBsxsFogMaP8hc7yPJYs_20JwK562ay4aOwE9rZ=33dipPoKQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 25, 2021 at 12:07 AM Noah Misch <noah(at)leadboat(dot)com> wrote:
>
> > In the refactoring patch, there is a lingering comment reference to
roles_has_privs_of(). Aside from that, it looks good to me. A possible
thing to consider is an assert that is_admin is not null where we expect
that.
>
> Thanks. The next version will contain the comment fix and
> "Assert(OidIsValid(admin_of) == PointerIsValid(is_admin));".
>
> > The database owner role patch looks good as well.
>
> Do you plan to put the CF entry into Ready for Committer, or should the
> patches wait for another review?

I've marked it Ready for Committer.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2021-03-25 13:56:55 Re: [UNVERIFIED SENDER] Re: Challenges preventing us moving to 64 bit transaction id (XID)?
Previous Message David Steele 2021-03-25 13:42:35 Re: Polyphase merge is obsolete