Re: cleanup patches for incremental backup

On Tue, 16 Jan 2024 at 21:49, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Tue, Jan 16, 2024 at 3:22 PM Matthias van de Meent
> <boekewurm+postgres(at)gmail(dot)com> wrote:
> + A special <glossterm linkend="glossary-basebackup">base backup</glossterm>
> + that for some WAL-logged relations only contains the pages that were
> + modified since a previous backup, as opposed to the full relation data of
> + normal base backups. Like base backups, it is generated by the tool
> + <xref linkend="app-pgbasebackup"/>.
>
> Could we say "that for some files may contain only those pages that
> were modified since a previous backup, as opposed to the full contents
> of every file"?

Sure, added in attached.

> + To restore incremental backups the tool <pgcombinebackup>
> + is used, which combines the incremental backups with a base backup and
> + [...]
> I wondered if this needed to be clearer that the chain of backups
> could have length > 2. But on further reflection, I think it's fine,
> unless you feel otherwise.

I removed "the" from the phrasing "the incremental backups", which
makes it a bit less restricted.

> The rest LGTM.

In the latest patch I also fixed the casing of "Incremental Backup" to
"... backup", to be in line with most other multi-word items.

Thanks!

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)