| From: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
|---|---|
| To: | |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, David Christensen <david(at)pgguru(dot)net> |
| Subject: | Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2) |
| Date: | 2024-03-01 13:48:53 |
| Message-ID: | CAEze2Wiv2f_Y8EjFEXtmQsTKRk2XshCvBkyDzAWLWbqxMeXknA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 24 Jan 2024 at 13:02, Matthias van de Meent
<boekewurm+postgres(at)gmail(dot)com> wrote:
> > 1.
> > Commit message refers to a non-existing reference '(see [0])'.
>
> Noted, I'll update that.
>
> > 2.
> > +When we do a binary search on a sorted set (such as a BTree), we know that a
> > +tuple will be smaller than its left neighbour, and larger than its right
> > +neighbour.
> >
> > I think this should be 'larger than left neighbour and smaller than
> > right neighbour' instead of the other way around.
>
> Noted, will be fixed, too.
Attached is version 15 of this patch, with the above issues fixed.
It's also rebased on top of 655dc310 of this morning, so that should
keep good for some time again.
Kind regards,
Matthias van de Meent
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0001-btree-Implement-dynamic-prefix-compression.patch | application/octet-stream | 23.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-03-01 13:57:35 | Re: Commitfest Manager for March |
| Previous Message | Daniel Gustafsson | 2024-03-01 12:29:25 | Re: Commitfest Manager for March |